Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set runNow to false when editing existing workflows #1458

Merged
merged 2 commits into from Dec 18, 2023
Merged

Set runNow to false when editing existing workflows #1458

merged 2 commits into from Dec 18, 2023

Conversation

tw4l
Copy link
Contributor

@tw4l tw4l commented Dec 14, 2023

Fixes #1339

Screenshots

New workflow (only seed URL entered, everything else default)

Screen Shot 2023-12-14 at 4 10 37 PM

Editing existing workflow

Screen Shot 2023-12-14 at 4 12 27 PM

Testing

  1. Create new Workflow, verify Run on Save is enabled
  2. Edit existing Workflow, verify Run on Save is disabled

Shrinks99
Shrinks99 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@Shrinks99 Shrinks99 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good fix! Works! 🚀

@tw4l tw4l requested a review from SuaYoo December 18, 2023 17:56
@tw4l tw4l merged commit 4fe0140 into main Dec 18, 2023
2 checks passed
@tw4l tw4l deleted the issue-1339-disable-run-on-save branch December 18, 2023 19:23
tw4l added a commit that referenced this pull request Dec 19, 2023
@tw4l
Set runNow to false when editing existing workflows (#1458)
8ff9b91 
Fixes #1339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shrinks99 Shrinks99 Shrinks99 approved these changes

@emma-sg emma-sg Awaiting requested review from emma-sg

@ikreymer ikreymer Awaiting requested review from ikreymer

@SuaYoo SuaYoo Awaiting requested review from SuaYoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Change]: Disable Run on Save toggle by default when editing workflow
3 participants
@tw4l @SuaYoo @Shrinks99