Encode Non-ASCII HTTP Headers #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tempt to %-encode any non-ascii headers as utf-8 as specified in RFC 5987, RFC 8187 Add StatusAndHeaders.to_ascii_bytes() which ensures an ascii only encoding of the headers Addresses #38
N0taN3rd
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address the issue in #38, add %-encoding of HTTP headers that are non-ascii.
(While latin-1/iso-8859-1 headers are technically allowed, to be extra safe all non-ascii headers are encoded)
If a header such as:
it will be converted to:
before being written to WARC (per https://tools.ietf.org/html/rfc8187#section-3.2.3)
Adds
StatusAndHeaders.to_ascii_bytes()to perform this conversion where necessary.