New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use error enums instead of Anyhow #106
Comments
First stab at |
@rainliu Would you mind looking at the two first PRs? I'm wondering what you think about it so far. I've hard to maintain the convenience of |
@algesten, thanks for the efforts. PR for sdp crate looks good to me. and I leave some comments on PR for util crate. |
Alright. That's all for me for today. I'll continue tomorrow. |
@rainliu I believe this is done. The next step is probably reviewing, merging and releasing new versions of the subcrates. |
@rainliu I've fixed clippy lints in all the PRs, and also speculatively bump deps everywhere. I assumed since this is a breaking change, we're doing minor revisions everywhere. This is the version plan I've bumped to:
|
The idea is that if you merge/bump (to the version above)/release in the right order, it should "just work" |
Original discussion on discord, and further issue raised here: webrtc-rs/rtp#14
Anyhow is great, but maybe not a good fit for webrtc.rs. To summarize:
std::error::Error
(it can't), which makes it hard to interoperate in apps that rely on that.anyhow::Result<X>
Way forward
thiserror
to help implement said enums.?
use internally in webrtc.rs (work with From traits and rewrap errors).This issue will be used to coordinate the effort which will span all the sub-crates.
The text was updated successfully, but these errors were encountered: