-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inactive tracks should not be stopped #192
Comments
Instead of stopping here's what I think should happen(based on my reading of the specifications): ReceivingIf we were receiving and now aren't because our local direction will become SendingSimilarly, if we were sending and receive an answer that changes our local direction to RFC8829 has the following to say about applying an answer that changes the direction such that sending is no longer happening.
It seems to me like we have an implicit state machine in Based on the language from RFC8829 it sounds like we'd want to extend this as follows Any sends on a bound track for a paused |
This issue duplicates #162, closing it. |
As showcased in #191 tracks that go from .e.g.
sendonly
toinactive
in the course of applying a remote offer(viaset_remote_description
) are stopped:webrtc/src/peer_connection/mod.rs
Lines 1314 to 1316 in de83067
My understanding of the specification is that when a media description becomes
inactive
that shouldn't cause the corresponding transceiver to stop.I took a stab at removing this stopping behaviour because it causes the bug in #191 and that works‚ in so far that, it stops the endless loop.
On the JS side reactivating the media description via
and negotiating does not cause
webrtc-rs
to bring the transceiver back frominactive
torecvonly
.The text was updated successfully, but these errors were encountered: