Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Perfect Negotiation sample page #1352

Closed
henbos opened this issue Sep 9, 2020 · 4 comments · Fixed by #1384
Closed

Add Perfect Negotiation sample page #1352

henbos opened this issue Sep 9, 2020 · 4 comments · Fixed by #1384

Comments

@henbos
Copy link
Member

henbos commented Sep 9, 2020

In M87, Chromium-based browsers support the Perfect Negotiation pattern - for more info, see PSA.

We should add a web page that illustrates this pattern, similar to this jsfiddle (referenced by the PSA).

@henbos
Copy link
Member Author

henbos commented Sep 9, 2020

@jan-ivar @alvestrand I think we can improve on the demo and add it to the samples page, but I don't know when there would be time to do that (for me personally)

@henbos
Copy link
Member Author

henbos commented Sep 9, 2020

I think we should make the sample page such that the Perfect Negotiation logic is a separate .js file like a "library" that you make use of in the sample page, to show how "plug-and-play" the pattern is.

@SCG82
Copy link
Contributor

SCG82 commented Nov 24, 2020

Perhaps someone can add tests and polish my draft PR #1384 (unfortunately I won't have any time in the near future to work on it).

@henbos
Copy link
Member Author

henbos commented Nov 27, 2020

Thank you @SCG82, it's now at https://webrtc.github.io/samples/src/content/peerconnection/perfect-negotiation/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants