Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScriptProcessorNode deprecated in Chrome 121. #1649

Closed
benbro opened this issue Feb 10, 2024 · 1 comment
Closed

ScriptProcessorNode deprecated in Chrome 121. #1649

benbro opened this issue Feb 10, 2024 · 1 comment

Comments

@benbro
Copy link

benbro commented Feb 10, 2024

  • [ +] I understand that issues created here are only relevant to the samples in this repo - not browser or SDK bugs
  • [ +] I have provided steps to reproduce
  • [ +] I have provided browser name and version
  • [ +] I have provided a link to the sample here or a modified version thereof

Browser affected

Chrome 121.0.6167.160

Description

ScriptProcessorNode is deprecated in Chrome 121 but still works.
Console warning suggests to use AudioWorkletNode. Supported on all browsers and Safari 14.1:
https://developer.mozilla.org/en-US/docs/Web/API/AudioWorklet#browser_compatibility
https://github.com/webrtc/samples/blob/gh-pages/src/content/getusermedia/volume/js/soundmeter.js#L21

Steps to reproduce

Open demo in Chrome 121:
https://webrtc.github.io/samples/src/content/getusermedia/volume/

Expected results

No console warning.

Actual results

Console warning.

soundmeter.js:21 [Deprecation] The ScriptProcessorNode is deprecated. Use AudioWorkletNode instead. (https://bit.ly/audio-worklet)
@fippo
Copy link
Collaborator

fippo commented Feb 17, 2024

see #1509

@fippo fippo closed this as completed Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants