Missing callbacks to setLocalDescription break FF nightly

[fippo]

I just ran into an issue where FF nightly (33.0a1 2014-06-15) refused to work with the datachannel sample. It turned out that it failed because the success/error callbacks to setLocalDescription are missing (they're not optional per spec).
See e.g. https://github.com/GoogleChrome/webrtc/blob/master/samples/web/content/datachannel/js/main.js#L119

This seems to be used quite often, do a
grep -r setLocalDescription * | grep ')'
in the content directory.

I'll see if I can provide a patch.

[juberti]

OK. @marwahvikas can help.

[fippo]

style-question before I start: is there a preferred way we can share the error callbacks among all demos? I tend to just pass console.error there.

I'll try to ignore that createAnswer is sometimes not called from the setRemoteDescription success callback for now. Another (style) issue.

Otherwise this seems straightforward.

[samdutton]

is there a preferred way we can share the error callbacks among all demos? I tend to just pass console.error there.

Do you mean some error callback code to be used by all demos? Not at present. For the moment at least, I think it probably makes sense for individual demos to use their own handlers.

Whether to use the console or window.alert() (or both) depends on the context.

console.error is sensible for errors, though the existing demos use the plain old console.log. I've raised an issue to fix this: #130. On a tangent – the console API is quite powerful, and we should probably make more of it: https://developer.chrome.com/devtools/docs/console#using-the-console-api.

[fippo]

@samdutton what I am worried about (long-term) is putting stuff in adapter.js that isn't shimming browser differences.

(see also the discussion in #74)

[fippo]

nightly no longer insists since this is not possible to detect with the promise-based versions.