mediarecorder: add dropdown for codec selection #1424
Conversation
fippo
force-pushed
the
mediarecorder-improvements
branch
from
8bf78a6
to
bc75df4
Compare
| @@ -32,7 +34,8 @@ recordButton.addEventListener('click', () => { | |||
|
|
|||
| const playButton = document.querySelector('button#play'); | |||
| playButton.addEventListener('click', () => { | |||
| const superBuffer = new Blob(recordedBlobs, {type: 'video/webm'}); | |||
| const mimeType = codecPreferences.options[codecPreferences.selectedIndex].value.split(';', 1)[0]; | |||
There was a problem hiding this comment.
I would have preferred to use mediaRecorder.mimeType here but it is
"video/x-matroska;codecs=avc1,opus"
when one selects H264
There was a problem hiding this comment.
Correct, and also l.75 won't work because MP4 container is not supported.
These two files should give an idea of what's exactly supported:
- https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/fast/mediarecorder/MediaRecorder-isTypeSupported-avc1.html?q=istypesupported
- https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/fast/mediarecorder/MediaRecorder-isTypeSupported.html
There was a problem hiding this comment.
Also another note, IIRC the ondataavailable event listener's event.data.type should carry the actual mimeType used in the recording (which might be slightly different from the one specified):
There was a problem hiding this comment.
line 75 is for Safari which presumably only supports MP4 -- see https://webkit.org/blog/11353/mediarecorder-api/
It doesn't work in Chrome but that just means it will be filtered.
e.data.type is the same as mediaRecorder.mimeType
for easier testing of issues like https://bugs.chromium.org/p/chromium/issues/detail?id=117681 and Safari support
fippo
force-pushed
the
mediarecorder-improvements
branch
from
bc75df4
to
3325e8e
Compare
|
@yellowdoge can you please take a look? |
| @@ -32,7 +34,8 @@ recordButton.addEventListener('click', () => { | |||
|
|
|||
| const playButton = document.querySelector('button#play'); | |||
| playButton.addEventListener('click', () => { | |||
| const superBuffer = new Blob(recordedBlobs, {type: 'video/webm'}); | |||
| const mimeType = codecPreferences.options[codecPreferences.selectedIndex].value.split(';', 1)[0]; | |||
There was a problem hiding this comment.
Correct, and also l.75 won't work because MP4 container is not supported.
These two files should give an idea of what's exactly supported:
- https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/fast/mediarecorder/MediaRecorder-isTypeSupported-avc1.html?q=istypesupported
- https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/web_tests/fast/mediarecorder/MediaRecorder-isTypeSupported.html
| @@ -32,7 +34,8 @@ recordButton.addEventListener('click', () => { | |||
|
|
|||
| const playButton = document.querySelector('button#play'); | |||
| playButton.addEventListener('click', () => { | |||
| const superBuffer = new Blob(recordedBlobs, {type: 'video/webm'}); | |||
| const mimeType = codecPreferences.options[codecPreferences.selectedIndex].value.split(';', 1)[0]; | |||
There was a problem hiding this comment.
Also another note, IIRC the ondataavailable event listener's event.data.type should carry the actual mimeType used in the recording (which might be slightly different from the one specified):
for easier testing of issues like
https://bugs.chromium.org/p/chromium/issues/detail?id=117681
and Safari support