Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter-lestest.js would change my constructor #1010

Closed
SuuuuperAA opened this issue Nov 7, 2019 · 1 comment
Closed

adapter-lestest.js would change my constructor #1010

SuuuuperAA opened this issue Nov 7, 2019 · 1 comment

Comments

@SuuuuperAA
Copy link

Please read first!

  • [√] I have provided browser name, version and adapter.js version
  • [√] This issue only happens when adapter.js is used

Versions affected

Browser name including version (e.g. Chrome 64.0.3282.119,and 360 browser)

adapter.js (e.g. 6.1.0)

Description

I used arcgis for javascript to build map,The way a functional module is introduced is the asynchronous loading of require,One of these modules is correctly loaded as a constructor the first time it's loaded, but the second time it's loaded it's changed to an object that contains basic browser information.This problem was eliminated when I removed adapter-lestest. Js, and it didn't appear in the Google browser, it appeared in the 360 browser, and I haven't tested the other browsers.I found several problems with the same name and changed the naming, but the problem remained,help me please~

@fippo
Copy link
Member

fippo commented Jan 10, 2020

https://webrtc.github.io/adapter/adapter-latest.js will export itself as window.adapter. If you don't want that try https://github.com/webrtcHacks/adapter/blob/gh-pages/adapter-7.4.0-variants/adapter_no_global.js

Alternatively, don't use the pre-built version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants