Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for all public functions in adapter.js to detect interop issues #47

Closed
KaptenJansson opened this issue Jun 9, 2015 · 2 comments

Comments

@KaptenJansson
Copy link
Collaborator

webrtc/samples#523 was caused by webrtc/adapter@04af828 where window.createIceServer was removed.

We should add tests for this, just a rudimentary check like "typeof foo !== undefined" for all expected public api functions/methods is better than nothing.

Also its easier then to make sure that when we do break something we properly update the version number to indicate it's incompatible.

@kashifshamaz21
Copy link

+1, this would be very helpful as webrtc apis are still under changes and lot of interop issues are expected for now.

@KaptenJansson
Copy link
Collaborator Author

Believe this has been solved in the refactoring of adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants