Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getDisplayMedia to navigator.mediaDevices #896

Closed
jan-ivar opened this issue Oct 31, 2018 · 3 comments · Fixed by #897
Closed

Move getDisplayMedia to navigator.mediaDevices #896

jan-ivar opened this issue Oct 31, 2018 · 3 comments · Fixed by #897
Assignees
@fippo

Comments

@jan-ivar
Copy link
Collaborator

A heads-up that getDisplayMedia just moved to navigator.mediaDevices.getDisplayMedia in w3c/mediacapture-screen-share#86.

We should update adapter.js to match ASAP.
@jan-ivar jan-ivar mentioned this issue Oct 31, 2018
Closed
@fippo fippo self-assigned this Oct 31, 2018
@fippo
Copy link
Member

fippo commented Oct 31, 2018 •
edited

yes, probably worth a patch release of the old version. I suspect we'll need to keep the old version around for a while. But MAYBE add a deprecation warning :-)

@jan-ivar can you add a note to the blog post?

@jan-ivar
Copy link
Collaborator Author

Done. Thanks @fippo for the reminder!

@fippo
Copy link
Member

fippo commented Nov 1, 2018

How do we handle backward compat? Do we shim navigator.getDisplayMedia if navigator.mediaDevices.getDisplayMedia is available natively?

@fippo fippo mentioned this issue Nov 1, 2018
Merged
@fippo fippo closed this as completed in #897 Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fippo fippo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

shim navigator.mediaDevices.getDisplayMedia webrtcHacks/adapter
2 participants
@fippo @jan-ivar