Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce leaking globals and create an explicit function exposing the globals we need. #130

Closed
KaptenJansson opened this issue Aug 19, 2015 · 5 comments
Closed

Reduce leaking globals and create an explicit function exposing the globals we need. #130

KaptenJansson opened this issue Aug 19, 2015 · 5 comments
Labels
enhancement

Comments

@KaptenJansson
Copy link
Collaborator

No description provided.

@juberti
Copy link
Contributor

juberti commented Aug 24, 2015

Is this the same as #8?

@alvestrand
Copy link
Contributor

Christoffer and I talked about this last week. If adopted, it would ameliorate #8, but it's more of a specific approach than a generic.
We've got users depending on those globals now, so pulling them in requires at least a major version bump.

@fippo
Copy link
Member

fippo commented Sep 30, 2015

the samples are now ready for a version bump so let's do it along with Edge support.

@KaptenJansson
Copy link
Collaborator Author

Being done in #164.

@KaptenJansson
Copy link
Collaborator Author

Fixed in #164.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fippo @alvestrand @juberti @KaptenJansson