Skip to content

Commit

Permalink
Fix a bunch of minor things for streaming during PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
pthatcherg committed Sep 6, 2019
1 parent 17c2c3a commit 5975060
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 12 deletions.
14 changes: 7 additions & 7 deletions index.bs
Expand Up @@ -1489,7 +1489,7 @@ streaming-session-start-request message with the following properties:
receiver) pair. Can be used later to modify or terminate a
streaming session.

: stats-interval
: desired-stats-interval
:: Indicates the frequency the receiver should send stats messages to
the sender.

Expand Down Expand Up @@ -1599,7 +1599,7 @@ After receiving a streaming-session-start-request message, a receiver
should send back a streaming-session-start-response message with the
following properties:

: stats-interval
: desired-stats-interval
:: Indicates the frequency the sender should send stats messages to
the receiver.

Expand Down Expand Up @@ -1669,13 +1669,13 @@ separate QUIC streams.
helps to avoid sending duplicate information in every frame.

: start-time
:: Identifies the beginning of the time range of the audio frame. The time
:: Identifies the beginning of the time range of the audio frame. The time
scale is inferred from the properties of the encoding (from the
audio-encoding-offer). The end time can be inferred from the
start time and duration.

: duration
:: If present, the duration of the audio frame. The time
:: If present, the duration of the audio frame. The time
scale is inferred from the properties of the encoding. Likewise, if not
present, the duration is inferred from the properties of the encoding.

Expand Down Expand Up @@ -1724,14 +1724,14 @@ ending at the last dependent frame.
If not present, the default value is [-1].

: start-time
:: Identifies the beginning of the time range of the video frame. The time
:: Identifies the beginning of the time range of the video frame. The time
scale is inferred from the properties of the encoding (from the
video-encoding-offer). The end time can be inferred from the
start time and duration.

: duration
:: If present, the duration of the video frame. The time
scale is inferred from the properties of the encoding. If not
:: If present, the duration of the video frame. The time
scale is inferred from the properties of the encoding. If not
present, that means duration is unknown.

: sync-time
Expand Down
17 changes: 12 additions & 5 deletions messages_appendix.cddl
Expand Up @@ -505,7 +505,7 @@ video-resolution = {
receive-video-capability = {
0: format ; codec
? 1: video-resolution ; max-resolution
? 2: uint ; max-frames-per-second
? 2: ratio ; max-frames-per-second
? 3: uint ; max-pixels-per-second
? 4: uint ; min-bit-rate
? 5: ratio ; aspect-ratio
Expand All @@ -523,15 +523,15 @@ streaming-session-start-request = {
request
1: uint; streaming-session-id
2: [* media-stream-offer] ; stream-offers
3: microseconds ; stats-interval
3: microseconds ; desired-stats-interval
}

; type key 135
streaming-session-start-response = {
response
1: &result ; result
2: [* media-stream-request] ; stream-requests
3: microseconds ; stats-interval
3: microseconds ; desired-stats-interval
}

; type key 136
Expand Down Expand Up @@ -608,7 +608,7 @@ audio-encoding-request = {
video-encoding-request = {
1 : uint ; encoding-id
? 2 : video-resolution ; target-resolution
? 3 : float32 ; max-frames-per-second
? 3 : ratio ; max-frames-per-second
}

data-encoding-request = {
Expand All @@ -635,7 +635,7 @@ video-frame = {
3: uint ; start-time
? 4: uint ; duration
5: bytes ; payload
? 6: uint ; rotation
? 6: uint ; video-rotation
? 7: media-time ; sync-time
}

Expand Down Expand Up @@ -663,6 +663,13 @@ ratio = [
consequent: uint
]

video-rotation = &(
; Degrees clockwise
video-rotation-0
video-rotation-90
video-rotation-180
video-rotation-270
)

; type key 142
streaming-session-sender-stats-event = {
Expand Down

0 comments on commit 5975060

Please sign in to comment.