Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Protocol] Clarify scoping/uniqueness of request IDs #139

Closed
mfoltzgoogle opened this issue Mar 5, 2019 · 4 comments
Closed

[Protocol] Clarify scoping/uniqueness of request IDs #139

mfoltzgoogle opened this issue Mar 5, 2019 · 4 comments

Comments

@mfoltzgoogle
Copy link
Contributor

The spec states,

A request and a response includes a request ID which is an unsigned integer chosen by the requester. Responses must include the request ID of the request they are associated with.

In implementing the library, we need to know

  • Are request IDs unique per-connection or across connections to the same agent?
  • What happens if a request is sent on one connection and a response on another?
  • Do they need to be unique across agents/endpoints (implying that some per-endpoint data needs to be mixed in)?

Steps in the spec to allocate the next request ID could address these questions.

@mfoltzgoogle
Copy link
Contributor Author

Additional things to address:

  • If we allow the request ID counter to span connections, are the endpoints required to keep this state, or should we add something to the protocol to relay the next request ID on a new connection?
  • Do the IDs need to be unique for requests across the client and server sides of the connection? Suggest using even/odd numbers to address this.

@calvaris
Copy link

calvaris commented Mar 6, 2019

I think they should be unique per session to reduce user tracking, right?

@mfoltzgoogle
Copy link
Contributor Author

Re: #139 (comment)

There's no direct relationship between the request and watch IDs and individual users/connections. It's just a counter that's kept per-device and occasionally reset. I don't think they would be useful for tracking users, but take a look and see what you think.

@mfoltzgoogle
Copy link
Contributor Author

Resolved by PR #181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants