Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds terminology and requirements to spec. #103

Merged
merged 4 commits into from Sep 4, 2018

Conversation

mfoltzgoogle
Copy link
Contributor

@mfoltzgoogle mfoltzgoogle commented Aug 28, 2018

Addresses Issue #99 to complete the introduction, terminology and requirements section (excepting that for Remote Playback API). This is a lightly edited version of the content in requirements.md.

Note: Use the initialize-spec as the base branch for this PR.

Editor's notes:

A best effort was undertaken to leverage Bikeshed's autolinking functionality. Specifically, the Second Screen specs are not in the Bikeshed database, so terms have to be defined in an "anchors" block at the beginning of the document. In that block, I didn't see a way to define shortened forms, e.g. ("controller" for "controlling browsing context"), so they will need to be linked in the upstream spec, or perhaps there's a Bikeshed feature I'm missing.

Copy link
Contributor

@louaybassbouss louaybassbouss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfoltzgoogle LGTM. Since the index.html is auto-generated, I only reviewed index.bs

index.bs Outdated Show resolved Hide resolved
@mfoltzgoogle
Copy link
Contributor Author

Merging now - if there are any follow up comments, feel free to add to this thread or open an issue.

@mfoltzgoogle mfoltzgoogle merged commit 77585e0 into initialize-spec Sep 4, 2018
@mfoltzgoogle mfoltzgoogle deleted the spec-requirements branch September 4, 2018 18:05
mfoltzgoogle added a commit that referenced this pull request Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants