Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds non-functional requirements for user experience. Additional editing. #15

Merged
merged 4 commits into from Jan 28, 2017
Merged

Adds non-functional requirements for user experience. Additional editing. #15

merged 4 commits into from Jan 28, 2017

Conversation

mfoltzgoogle
Copy link
Contributor

@mfoltzgoogle mfoltzgoogle commented Jan 13, 2017 •
edited

For Issue #4: Non-functional requirements

PTAL @schien @tidoust @anssiko et al.

New content:

  • Adds non-functional requirements around user experience.
  • Adds a document listing specs of devices that might be used as controllers and receivers.

Editing:

  • Link Presentation API terms to definitions in the spec.
  • Clarify text in a few places.
  • Improve capitalization and indentation consistency.
  • Use more readable anchor names.

schien
schien reviewed Jan 18, 2017
View reviewed changes
Copy link
Contributor

@schien schien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall lgtm.

requirements.md

2. The protocol should prevent passive network attackers from learning
2. The protocol should prevent passive network observers from learning
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eavesdroppers?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed.

@anssiko
Copy link
Member

anssiko commented Jan 18, 2017

This is a great first stab. My expectation is we'll fill in the gaps re devices to be used in evaluation as the work commences. I should be able to help get hands on PC hardware needed for evaluation.

@anssiko
Copy link
Member

anssiko commented Jan 24, 2017

@mfoltzgoogle I would recommend landing the PR to attract more eyeballs. My hunch is people are more likely to contribute when they see the content in the .md files in the repo.

If you prefer, could mark WIP documents as such for clarity.

@mfoltzgoogle mfoltzgoogle merged commit 60fc916 into gh-pages Jan 28, 2017
@mfoltzgoogle mfoltzgoogle deleted the issue-1-additional-requirements branch January 28, 2017 00:23
@mfoltzgoogle
Copy link
Contributor Author

Thanks @schien and @anssiko, merged.

@mfoltzgoogle mfoltzgoogle mentioned this pull request Jan 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schien schien schien left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mfoltzgoogle @anssiko @schien