Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYPO3 v12 compatibility #31

Open
RTPAst opened this issue Jun 5, 2023 · 3 comments
Open

TYPO3 v12 compatibility #31

RTPAst opened this issue Jun 5, 2023 · 3 comments

Comments

@RTPAst
Copy link

RTPAst commented Jun 5, 2023

Is a version for TYPO3 v12 to be expected in the near future?
@mrwhy-orig
Copy link

I've updated my repo and made a pull request . Feel free to test it. #32

@RTPAst
Copy link
Author

RTPAst commented Aug 23, 2023

The whole thing looks pretty good already, in the following files the ObjectManager is used, this is deprecated in TYPO3 V12:

  • Classes/Resource/Rendering/VimeoRenderer.php
  • Classes/Resource/Rendering/YouTubeRenderer.php

Delete the line with ObjectManager and replace $objectManager->get( with GeneralUtility::makeInstance(.
And in the composer.json file, the TYPO3 V12 version is missing in the required value.

@RTPAst
Copy link
Author

RTPAst commented Sep 6, 2023 •
edited
Loading

The following class also has a mistake

  • Classes/Resource/Rendering/VimeoRenderer.php

the replace param data-name="youtube" ... must replace with data-name="vimeo" ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrwhy-orig @RTPAst