Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[if] Shortcode Pro v170220.78352-RC #3

Closed
raamdev opened this issue Feb 20, 2017 · 5 comments
Closed

[if] Shortcode Pro v170220.78352-RC #3

raamdev opened this issue Feb 20, 2017 · 5 comments
Assignees

Comments

@raamdev
Copy link
Contributor

raamdev commented Feb 20, 2017

Downloads

Please see the download links in Slack:
https://websharks.slack.com/archives/if-shortcode/p1487627335000012

Changelog

v170220.78352-RC

  • Bumping minimum required version of the WP Sharks Core.
  • Bumping minimum required WordPress version to v4.6.
  • Adding support for wp-markdown-extra filter configuration.
  • Removing unnecessary nested shortcode callback handler. Starting with WP 4.6 the new WP_Hook class addresses the underlying problem this was solving. See Issue #1.
  • Enhancing security be removing basename(__FILE__) from direct access notices.
  • Removing unnecessary lite build variation from .build.props file.

Reporting Issues / Feedback

Please report any issues or feedback related to this Release Candidate using this GitHub issue. Please post a comment below with details.

If you are reporting a UI-related issue, please include a screenshot.

If you are reporting a bug, please provide list of steps to reproduce and if the bug is related to an existing GitHub issue, please provide a link to that GitHub issue as well.


Reported Issues to Fix

None at this time.

@renzms
Copy link

renzms commented Feb 22, 2017

Tested

  • Enhancing security be removing basename(FILE) from direct access notices.

  • Bumping minimum required version of the WP Sharks Core.

  • Adding support for wp-markdown-extra filter configuration.

  • Removing unnecessary nested shortcode callback handler. Starting with WP 4.6 the new WP_Hook class addresses the underlying problem this was solving. See Issue Next Gen Hooks: Upcoming Change in WP 4.7 #1.

  • Removing unnecessary lite build variation from .build.props file.

  • Bumping minimum required WordPress version to v4.6.

@renzms
Copy link

renzms commented Feb 23, 2017

screen shot 2017-02-23 at 10 08 32 pm

Should the notes regarding JetPack and Markdown be more visible? Such as a note underneath the option, rather than in the question mark pop-up? I feel like more casual users would miss this note. :)

Also, was unable to find WP Markdown Extra as a plugin, but according to Jetpack, it utilizes it as a Writing Option.

If you are already familiar with Markdown, just enable it on your blog and start writing; refer to the WordPress.com Markdown Quick Reference page for help. Jetpack uses Markdown Extra, which adds some features not originally available in Markdown. For best results, please use the Text tab in the Editor as the Visual editor can give unexpected results. See below for more details.

@renzms
Copy link

renzms commented Feb 23, 2017

@jaswsinc @raamdev

Everything seems to be working great.

No bugs to report, is there anything else I should test specifically for failure?

The Markdown Extra + Jetpack support work awesome.

Markdown Extra + Jetpack

screen shot 2017-02-23 at 10 27 31 pm

Back End Shortcode

screen shot 2017-02-23 at 10 30 01 pm

Front end logged-in

screen shot 2017-02-23 at 10 30 21 pm

Front end logged-out

screen shot 2017-02-23 at 10 31 30 pm

This works for both conditions of Jetpack / Markdown Extra support since Markdown Extra is integrated with Jetpack.

screen shot 2017-02-23 at 10 36 13 pm

screen shot 2017-02-23 at 10 36 29 pm

When the option is off, Markdown is only supported outside the if shortcodes as intended.

screen shot 2017-02-23 at 10 36 43 pm

screen shot 2017-02-23 at 10 36 57 pm

@raamdev
Copy link
Contributor Author

raamdev commented Feb 23, 2017

@renzms Thanks for the testing! That's all we need. :-) I'll put out a GA release soon.

@raamdev
Copy link
Contributor Author

raamdev commented Apr 7, 2017

Republishing this RC, as I forgot to follow up here with a GA release. See #4.

@raamdev raamdev closed this as completed Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants