Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distributables should not contain composer.json or composer.lock files #141

Closed
raamdev opened this issue Aug 24, 2016 · 2 comments
Closed

Distributables should not contain composer.json or composer.lock files #141

raamdev opened this issue Aug 24, 2016 · 2 comments
Labels
bug

Comments

@raamdev
Copy link
Contributor

raamdev commented Aug 24, 2016

While building Comment Mail Lite v160824, I noticed that the following composer.json and composer.lock files made it into the distributable zip:

composer.json
composer.lock
src/vendor/erusev/parsedown/composer.json
src/vendor/erusev/parsedown-extra/composer.json
src/vendor/websharks/wp-php-rv/composer.json
src/vendor/websharks/sharkicons/composer.lock
src/vendor/websharks/sharkicons/composer.json

If I'm not mistaken, these should be excluded from the distributables, since they're only applicable when building the project (i.e., they belong in the repo, but not in the distributable).
@raamdev raamdev added the bug label Aug 24, 2016
raamdev added a commit to wpsharks/comet-cache-pro that referenced this issue Sep 17, 2016
@raamdev
Exclude composer.json and composer.lock files from distributables
bbb635d 
See wpsharks/phings#141
@raamdev
Copy link
Contributor Author

raamdev commented Sep 17, 2016

↑ FYI, I'm excluding composer.json and composer.lock via the .build.props file in the Comet Cache project until this bug is fixed.

@raamdev raamdev mentioned this issue Dec 21, 2016
Closed
@raamdev
Copy link
Contributor Author

raamdev commented Dec 21, 2016

Related: #150

jaswrks pushed a commit that referenced this issue Dec 21, 2016
Preparing pull request. See: #141
5f64049
@jaswrks jaswrks mentioned this issue Dec 21, 2016
Merged
jaswrks pushed a commit that referenced this issue Dec 21, 2016
Exclude composer.json and composer.lock from final distros. See […
be349e3 
…Issue #141](#141)
@jaswrks jaswrks closed this as completed Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@raamdev @jaswrks