Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: composer.json Dependencies in Lite Variation #146

Closed
jaswrks opened this issue Sep 17, 2016 · 3 comments
Closed

Bug: composer.json Dependencies in Lite Variation #146

jaswrks opened this issue Sep 17, 2016 · 3 comments
Labels

Comments

@jaswrks
Copy link
Contributor

jaswrks commented Sep 17, 2016

@raamdev writes...

when building Comet Cache, the Lite distributable contains modules that should not be there (src/vendor/websharks/js-minifier/, src/vendor/websharks/html-compressor/, src/vendor/websharks/css-minifier/).

@jaswsinc writes...

I see. That's a bug. We need to find an elegant way of identifying dependencies that are not needed by the lite variation so that those can be excluded from the lite variation build.

@jaswrks jaswrks added the bug label Sep 17, 2016
@raamdev
Copy link
Contributor

raamdev commented Sep 17, 2016

I suppose these could just go in the .build.props file via project_lite_other_zip_tgz_fileset_exclusions.

@raamdev
Copy link
Contributor

raamdev commented Nov 18, 2016

Noting that I ran into this issue again during the Comment Mail v161118 release.

@raamdev
Copy link
Contributor

raamdev commented Dec 21, 2016

Related: #150

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants