New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Stripe Prepaid Card Option #1089

Closed
jaswrks opened this Issue May 17, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@jaswrks
Member

jaswrks commented May 17, 2017

See this line: https://github.com/websharks/s2member-pro/blob/170221/src/includes/classes/gateways/stripe/stripe-form-in.inc.php#L165

It uses the wrong default option value for the shortcode attribute, resulting in unexpected behavior associated with the ability to accept or deny prepaid cards in s2Member's Stripe integration.

@jaswrks jaswrks added the bug label May 17, 2017

@raamdev

This comment has been minimized.

Show comment
Hide comment
@raamdev

raamdev May 17, 2017

Member

@jaswrks Since it looks like the bug is with the global default, am I correct in assuming that manually setting reject_prepaid="0" in the Pro-Form shortcode will resolve this issue in the interim?

[s2Member-Pro-Stripe-Form level="1" ccaps="" ... reject_prepaid="0" ... /]
Member

raamdev commented May 17, 2017

@jaswrks Since it looks like the bug is with the global default, am I correct in assuming that manually setting reject_prepaid="0" in the Pro-Form shortcode will resolve this issue in the interim?

[s2Member-Pro-Stripe-Form level="1" ccaps="" ... reject_prepaid="0" ... /]
@jaswrks

This comment has been minimized.

Show comment
Hide comment
@jaswrks

jaswrks May 18, 2017

Member

@raamdev Yes, that's correct.

Member

jaswrks commented May 18, 2017

@raamdev Yes, that's correct.

jaswrks pushed a commit to websharks/s2member-pro that referenced this issue May 19, 2017

Jason Caldwell

@jaswrks jaswrks added this to the Next Release milestone May 19, 2017

@jaswrks jaswrks self-assigned this May 19, 2017

jaswrks pushed a commit that referenced this issue May 19, 2017

Jason Caldwell

jaswrks pushed a commit that referenced this issue May 19, 2017

Jason Caldwell
(s2Member Pro) **Bug Fix:** Incorrect default option value for `rejec…
…t_prepaid=""` attribute in Stripe Pro-Forms. See: [Issue #1089](#1089)

raamdev added a commit to websharks/s2member-pro that referenced this issue May 19, 2017

@raamdev

This comment has been minimized.

Show comment
Hide comment
@raamdev

raamdev May 24, 2017

Member

s2Member v170524 has been released and includes changes from this GitHub Issue. See the v170524 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#1089).

Member

raamdev commented May 24, 2017

s2Member v170524 has been released and includes changes from this GitHub Issue. See the v170524 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#1089).

@raamdev raamdev closed this May 24, 2017

@websharks websharks locked and limited conversation to collaborators May 24, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.