Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Stripe Prepaid Card Option #1089

Closed
jaswrks opened this issue May 17, 2017 · 3 comments
Closed

Bug: Stripe Prepaid Card Option #1089

jaswrks opened this issue May 17, 2017 · 3 comments
Assignees
@jaswrks
Labels
bug
Milestone
v170524

Comments

@jaswrks
Copy link
Contributor

jaswrks commented May 17, 2017 •
edited
Loading

See this line: https://github.com/websharks/s2member-pro/blob/170221/src/includes/classes/gateways/stripe/stripe-form-in.inc.php#L165

It uses the wrong default option value for the shortcode attribute, resulting in unexpected behavior associated with the ability to accept or deny prepaid cards in s2Member's Stripe integration.
@jaswrks jaswrks added the bug label May 17, 2017
@raamdev
Copy link
Contributor

raamdev commented May 17, 2017 •
edited
Loading

@jaswrks Since it looks like the bug is with the global default, am I correct in assuming that manually setting reject_prepaid="0" in the Pro-Form shortcode will resolve this issue in the interim?

[s2Member-Pro-Stripe-Form level="1" ccaps="" ... reject_prepaid="0" ... /]

@jaswrks
Copy link
Contributor Author

jaswrks commented May 18, 2017

@raamdev Yes, that's correct.

jaswrks pushed a commit to wpsharks/s2member-pro that referenced this issue May 19, 2017
Correct default option value. See: wpsharks/s2member#1089
a7f6fa9
@jaswrks jaswrks mentioned this issue May 19, 2017
Merged
@jaswrks jaswrks added this to the Next Release milestone May 19, 2017
@jaswrks jaswrks self-assigned this May 19, 2017
jaswrks pushed a commit that referenced this issue May 19, 2017
Preparing pull request. See: #1089
83c4a41
@jaswrks jaswrks mentioned this issue May 19, 2017
Merged
jaswrks pushed a commit that referenced this issue May 19, 2017
(s2Member Pro) **Bug Fix:** Incorrect default option value for `rejec…
7e437ca 
…t_prepaid=""` attribute in Stripe Pro-Forms. See: [Issue #1089](#1089)
raamdev added a commit to wpsharks/s2member-pro that referenced this issue May 19, 2017
@raamdev
Merge pull request #132 from websharks/feature/1089
3ba6126 
Correct default option value. See: wpsharks/s2member#1089
@raamdev
Copy link
Contributor

raamdev commented May 24, 2017

s2Member v170524 has been released and includes changes from this GitHub Issue. See the v170524 announcement for further details.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#1089).

@raamdev raamdev closed this as completed May 24, 2017
@wpsharks wpsharks locked and limited conversation to collaborators May 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jaswrks jaswrks

Labels
bug
Projects
None yet
Milestone
v170524
Development

No branches or pull requests
2 participants
@raamdev @jaswrks