Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desc field cut of after first " " (space) #426

Closed
extremecarver opened this issue Dec 31, 2014 · 10 comments
Closed

desc field cut of after first " " (space) #426

extremecarver opened this issue Dec 31, 2014 · 10 comments

Comments

@extremecarver
Copy link

Well, not s2member crashing my day just again...

For any Stripe ProForm - the desc "" content is only shown until the first whitespace... Workaround now for me use _ instead of normal "Space" " ".

@jaswrks
Copy link
Contributor

jaswrks commented Dec 31, 2014

Thanks for the report!

Can I get detailed steps on how to reproduce this please? I don't have any other reports of this, and I just ran a quick test with the default Stripe Pro Form shortcode (which uses whitespace in the desc=""); but I was unable to reproduce.

[s2Member-Pro-Stripe-Form level="1" ccaps="" desc="Bronze Member / Description and pricing details here." cc="USD" custom="jason.websharks-inc.net" ta="0" tp="0" tt="D" ra="0.51" rp="1" rt="M" rr="1" coupon="" accept_coupons="0" default_country_code="US" captcha="0" /]

2014-12-31_04-41-42

@extremecarver
Copy link
Author

[s2Member-Pro-Stripe-Form]
[s2Member-Pro-Stripe-Form level="1" ccaps="" desc="First_Year_for_20€_then_13€_Yearly_(recurring_charge,_for_ongoing_access)" cc="EUR" custom="www.velomap.org" ta="0" tp="1" tt="Y" ra="13" rp="1" rt="Y" rr="1" coupon="" accept_coupons="0" default_country_code="DE" captcha="0" /]
[s2Member-Pro-Stripe-Form level="1" ccaps="" desc="1_Year_@_1.50€_/_then_1.50_EUR_/ Yearly (recurring charge, for ongoing access)" cc="EUR" custom="www.velomap.org" ta="1.50" tp="1" tt="Y" ra="1.50" rp="1" rt="Y" rr="1" coupon="" accept_coupons="0" default_country_code="DE" captcha="0" /]
[s2Member-Pro-Stripe-Form level="1" ccaps="" desc="€0.50_EUR_One_Time_(for 1 year access, non-recurring, no trial)" cc="EUR" custom="www.velomap.org" ta="0" tp="0" tt="Y" ra="0.50" rp="1" rt="Y" rr="BN" coupon="" accept_coupons="0" default_country_code="DE" captcha="0" /]
[s2Member-Pro-Stripe-Form level="1" ccaps="" desc="20€_One_Time_Payment_for_1_year_access" cc="EUR" custom="www.velomap.org" ta="0" tp="0" tt="D" ra="20" rp="1" rt="Y" rr="BN" coupon="" accept_coupons="0" default_country_code="DE" captcha="0" /]
[s2Member-Pro-Stripe-Form level="1" ccaps="" desc="35€_One_Time_Payment_for_2_years_access" cc="EUR" custom="www.velomap.org" ta="0" tp="0" tt="D" ra="35" rp="2" rt="Y" rr="BN" coupon="" accept_coupons="0" default_country_code="DE" captcha="0" /]
[s2Member-Pro-Stripe-Form level="1" ccaps="" desc="45€_One_Time_Payment_for_3_years_access" cc="EUR" custom="www.velomap.org" ta="0" tp="0" tt="D" ra="45" rp="3" rt="Y" rr="BN" coupon="" accept_coupons="0" default_country_code="DE" captcha="0" /]
[s2Member-Pro-Stripe-Form level="1" ccaps="" desc="55€_One_Time_Payment_for_5_years_access" cc="EUR" custom="www.velomap.org" ta="0" tp="0" tt="D" ra="55" rp="5" rt="Y" rr="BN" coupon="" accept_coupons="0" default_country_code="DE" captcha="0" /]
[s2Member-Pro-Stripe-Form level="1" ccaps="" desc="80€_One_Time_Payment_for_10_years_access" cc="EUR" custom="www.velomap.org" ta="0" tp="0" tt="D" ra="80" rp="10" rt="Y" rr="BN" coupon="" accept_coupons="0" default_country_code="DE" captcha="0" /]
[s2Member-Pro-Stripe-Form level="1" ccaps="" desc="100€_One_Time_Payment_for_25_years_access(Lifetime)" cc="EUR" custom="www.velomap.org" ta="0" tp="0" tt="D" ra="100" rp="25" rt="Y" rr="BN" coupon="" accept_coupons="0" default_country_code="DE" captcha="0" /]
[/s2Member-Pro-Stripe-Form]

Ends up cut off here:
https://www.velomap.org/test3/stripe/

@jaswrks
Copy link
Contributor

jaswrks commented Dec 31, 2014

Referencing test page: http://jason.websharks-inc.net/stripe-desc-bug-test/

@jaswrks
Copy link
Contributor

jaswrks commented Dec 31, 2014

Ends up cut off here:
https://www.velomap.org/test3/stripe/

Can you define "cut off" for me? Here's a screenshot of what I see.

2014-12-31_04-52-42

@extremecarver
Copy link
Author

Yes - that screenshot is fine ..
Year@1.50€/then_1.50_EUR/ Yearly (recurring charge, for ongoing access)

So
" Yearly (recurring charge, for ongoing access)"
is cut off vs the code...

@jaswrks
Copy link
Contributor

jaswrks commented Dec 31, 2014

I see. Thank you.

I just ran a test with the exact same sequence of characters using the shortcodes that you posted prior. I'm running WordPress v4.1 and the latest release of s2Member. I'm unable to reproduce the "cut off" behavior.

2014-12-31_04-58-51

I'd suggest running this test again using a clean install (i.e. no other plugins, a default WP theme) and then see if you can reproduce it there. That may help narrow it down to a specific theme/plugin conflict.

@extremecarver
Copy link
Author

Well that happens even if I switch to default theme and no other plugins active! I guess its rather due to a newer PHP version - or something else:

I note that the server scanner is reporting wrong checksums - even though I reinstalled all s2member files and s2member pro...
https://www.velomap.org/test3/s2-server-scanner.php

@jaswrks
Copy link
Contributor

jaswrks commented Dec 31, 2014

Does removing the symbol make any difference on your end?

@extremecarver
Copy link
Author

Nope - stays broken... - But I don't have time to spend any more debugging on this for today...

@jaswrks
Copy link
Contributor

jaswrks commented Dec 31, 2014

Closing this issue. Unable to reproduce.

@extremecarver If you find out more about the issue (i.e. a way for us to reproduce) please reopen.

@jaswrks jaswrks closed this as completed Dec 31, 2014
@jaswrks jaswrks added this to the Next Release milestone Jan 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants