You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It would be useful to have an option on all three Quick Cache Exclusion option panels that allows a site owner to disable the Quick Cache HTML notes whenever a request matches an exclusion pattern.
This would be particularly useful when the HTML notes indicating a specific request is not being cached interferes with the request itself, such as when serving a gzipped XML feed in some server configurations (see #422 and this report).
The following Quick Cache options could have an additional section that allows for disabling HTML Notes whenever a request matches the exclusion pattern:
URI Exclusion Patterns
HTTP Referrer Exclusion Patterns
User-Agent Exclusion Patterns
The default would be to show HTML Notes when a request matches an exclusion pattern. Also, the global HTML Notes option in Quick Cache ⥱ Plugin Options ⥱ Enable/Disable would override these secondary options only when the global option is set to "No, don't show notes".
The text was updated successfully, but these errors were encountered:
In this report that you referenced above, I am not clear on how this could even occur. If GZIP is being handled by Nginx that should not impact the output of a PHP script, no matter what the output contains, i.e., HTML comment or no HTML comment.
Whenever GZIP is being handled by a secondary filter that resides outside of PHP, the deflating occurs after PHP output is generated. Thus, it would seem to me that the problem reported in that thread is related to a bug or misconfiguration of Nginx, not in ZenCache.
My guess is that the Nginx GZIP methodology being used is choking on the comment left at the bottom. Reproducing this would help to clarify. I'm just not really clear on how that can even happen unless there is a bug in the Nginx config.
The way it plays out is this...
Nginx receives a web request for a PHP file.
Nginx forks the request to PHP for processing.
Nginx receives the output from the PHP script.
Nginx is configured to enable GZIP output compression.
Nginx applies GZIP if the PHP script supplies a compressable Content-Type.
So how does one end up with an uncompressed comment line at the bottom?
It almost sounds like GZIP compression is being applied by PHP itself in this case, unbeknownst to ZenCache who then later adds the HTML comment line. If that's the case, it's an entirely different issue and we need to see if that can be reproduced at some point.
Removing the needs testing label, as this is just a feature request and this GitHub issue is not related to Jason's comment above. I haven't seen any further reports of issues with Nginx + GZIP + HTML Notes, so I'm not even going to fork that to a separate GitHub issue.
It would be useful to have an option on all three Quick Cache Exclusion option panels that allows a site owner to disable the Quick Cache HTML notes whenever a request matches an exclusion pattern.
This would be particularly useful when the HTML notes indicating a specific request is not being cached interferes with the request itself, such as when serving a gzipped XML feed in some server configurations (see #422 and this report).
The following Quick Cache options could have an additional section that allows for disabling HTML Notes whenever a request matches the exclusion pattern:
The default would be to show HTML Notes when a request matches an exclusion pattern. Also, the global HTML Notes option in
Quick Cache ⥱ Plugin Options ⥱ Enable/Disable
would override these secondary options only when the global option is set to "No, don't show notes".The text was updated successfully, but these errors were encountered: