Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change space root node to use sling:Folder or sling:OrderedFolder. #165

Open
wildone opened this issue May 16, 2023 · 4 comments
Open

Change space root node to use sling:Folder or sling:OrderedFolder. #165

wildone opened this issue May 16, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@wildone
Copy link

wildone commented May 16, 2023

Is your feature request related to a problem? Please describe.
Right now the space node uses a nt:Folder and this does not allow any more content be stored under this node. Can this be changed to use sling:Folder or even better sling:OrderedFolder? This would have much more benefits long term.

@wildone wildone added the enhancement New feature or request label May 16, 2023
@wildone wildone changed the title Change space root node to use sling:Folder. Change space root node to use sling:Folder or sling:OrderedFolder. May 16, 2023
@paweljozwicki
Copy link
Member

Hi, can you provide some more details, what do you mean by space node? If I checked correctly it uses ws:PagesSpace, but maybe I'm checking the wrong node?

@wildone
Copy link
Author

wildone commented May 22, 2023

This is for the /content/<space> folder as you cant add jcr:content node under it, its seems that its an nt:Folder as a base type.

@paweljozwicki
Copy link
Member

So, we use ws:PagesSpace there and I think we won't decide to change that, right now.

This is our dedicated node type and it only allows adding what we have designed for. We don't want to allow adding anything for which we haven't provided support.

But I think you can always use some mixin type if you want to add something.

@wildone
Copy link
Author

wildone commented Jul 13, 2023

Right now I need to add space level Config, so I had to create a work around. Keeping space level Config in one place sticks to sling principles.

Also just for the spirit of sling and jcr it's just make sense to have everything writable.

It won't impact any of you features and it will make the adoption more predictable as it will avoid needing to make side patterns.

You've already made a best decision to make space node which allows to store site specific content without making some remote locations like in AEM, make a space very portable. This will essentially fully reinforce that in theory and in practice.

It can still be custom node just could inherit from ordered folder to allow other nodes and ordering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants