Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dialogs with Multifield and Sidebar saving conflict #159

Closed
wildone opened this issue Apr 19, 2023 · 4 comments
Closed

Dialogs with Multifield and Sidebar saving conflict #159

wildone opened this issue Apr 19, 2023 · 4 comments
Labels
bug Something isn't working CMS Issue requires changes in CMS

Comments

@wildone
Copy link

wildone commented Apr 19, 2023

Description
Saving a dialog with a multifield gets overwritten rogue save from sidebar wipes changes.

Steps to reproduce

  1. Create a dialog with only a multifield
  2. Add it to page
  3. Update via dialog
  4. Update via sidebar

Current result
Currently, when you save via dialog correct values are saved, but a rogue save wipes data.

Expected behavior
If dialog save occurs not additional saves should occur.

Screenshots
dialogandsidebarsaveconflict

WebSight CMS version
1.12.0

@wildone wildone added the bug Something isn't working label Apr 19, 2023
@paweljozwicki paweljozwicki added the CMS Issue requires changes in CMS label Apr 19, 2023
@paweljozwicki
Copy link
Member

Thanks for noticing the issue.

@wildone
Copy link
Author

wildone commented Apr 26, 2023

Bit of a problem now, any official way to disable sidebar?

Can't deploy and edit content afterward as it disappears.

dialogandsidebarsaveconflict2

This is just clicking on components without any updates, it's just wiping content.

dialogandsidebarsaveconflict3

Sidepanel should be doing PATCH requests only to update fields as they come out of focus. Right not it's just doing silly stuff.

@paweljozwicki
Copy link
Member

Hi, the quickest workaround, for now, would be using "ws:disallowedContext": ["edit:panel"] property on multifield:
For example:

    "elements": {
        "sling:resourceType": "wcm/dialogs/components/multifield",
        "name": "elements",
        "label": "Elements",
        "ws:disallowedContext": ["edit:panel"],
        "labelText": {
          "sling:resourceType": "wcm/dialogs/components/textfield",
          "name": "label",
          "label": "Label"
    }

The field would be not available in the side panel, but still it would be possible to edit it in the dialog.

@paweljozwicki
Copy link
Member

Hi, the issue was resolved in WebSight 1.14.0. See release notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CMS Issue requires changes in CMS
Projects
None yet
Development

No branches or pull requests

2 participants