Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new maintainer wanted #71

Closed
DanielRuf opened this issue Jul 30, 2021 · 15 comments
Closed

new maintainer wanted #71

DanielRuf opened this issue Jul 30, 2021 · 15 comments

Comments

@DanielRuf
Copy link
Contributor

Hi, after many years of contributing to and creating opensource projects I will not invest much time in opensource anymore to focus on my personal life and more important things.

If you want to maintain this project, please leave a comment in this issue and tell a few things about you and your motivation.

@DanielRuf DanielRuf pinned this issue Jul 30, 2021
@myisaak
Copy link
Collaborator

myisaak commented Aug 7, 2021

HI @DanielRuf, I would gladly maintain this project. I'm passionate about and currently studying automation, which is why this project is interesting to me as it automates a lot of work as a web developer/security engineer. As it stands the project seems mature, but one can of course always add new websites and improve performance. Hope your new focus in life goes well!

@DanielRuf
Copy link
Contributor Author

Hi @myisaak,

Thank you very much. Please let me know how your npmjs handle is so I can add you to the org and package there too.

@myisaak
Copy link
Collaborator

myisaak commented Aug 24, 2021

Hey @DanielRuf here is my npmjs handle: https://www.npmjs.com/~myisaak

@DanielRuf
Copy link
Contributor Author

Thanks, I've tried to invite you to the website-checks org on npm but not sure if this happened because npmjs.com does not show your profile after sending the invitation.

@DanielRuf
Copy link
Contributor Author

You should have also received an email regarding your new owner rule here for https://github.com/website-checks/ so you should have all needed rights.

@DanielRuf
Copy link
Contributor Author

DanielRuf commented Aug 24, 2021

Please add points which I have probably missed and tick the things which are completed.

@myisaak
Copy link
Collaborator

myisaak commented Aug 26, 2021

LGTM. All boxes are ticked. Thanks!

@DanielRuf
Copy link
Contributor Author

LGTM. All boxes are ticked. Thanks!

Can you edit my comment to tick them with the [x]? =)

I have assigned owner rights for the website-checks org on npmjs so you should have all needed rights.
If not please let me know.

Many thanks for taking over and keeping this project alive =)

@myisaak
Copy link
Collaborator

myisaak commented Aug 27, 2021

You're welcome. I've edited the boxes with ticks in them.

@DanielRuf DanielRuf unpinned this issue Aug 27, 2021
@myisaak
Copy link
Collaborator

myisaak commented Aug 29, 2021

I'm still having issues publishing the package under my username myisaak, which is wierd since I see on the npm.js that I'm listed as write access to the website-checks package. When I enter publish I get the following

PS C:\Users\Isaak\Projects\js\website-checks> npm login                                                                                                                                                                            
npm notice Log in on https://registry.npmjs.org/                                                                                                                                                                                   
Username: myisaak                                                                                                                                                                                                                  
Password:                                                                                                                                                                                                                          
Email: (this IS public) isaak.eriksson@protonmail.com                                                                                                                                                                              
Enter one-time password from your authenticator app: 078312                                                                                                                                                                        
Logged in as myisaak on https://registry.npmjs.org/.                                                                                                                                                                               
PS C:\Users\Isaak\Projects\js\website-checks> npm publish                                                                                                                                                                          
npm notice                                                                                                                                                                                                                         
npm notice package: @website-checks/website-checks@1.20.0                                                                                                                                                                          
npm notice === Tarball Contents ===                                                                                                                                                                                                
npm notice 787B   Dockerfile                                                                                                                                                                                                       
npm notice 2.7kB  README.md                                                                                                                                                                                                        
npm notice 21B    .dockerignore                                                                                                                                                                                                    
npm notice 107B   .editorconfig                                                                                                                                                                                                    
npm notice 1.6kB  .github/workflows/codeql-analysis.yml                                                                                                                                                                            
npm notice 8.6kB  .github/workflows/main.yml                                                                                                                                                                                       
npm notice 0B     .sonarcloud.properties                                                                                                                                                                                           
npm notice 66B    bin/website-checks.js                                                                                                                                                                                            
npm notice 172B   docker-compose.yml                                                                                                                                                                                               
npm notice 1.2kB  index.js                                                                                                                                                                                                         
npm notice 468B   modules/check-function.js                                                                                                                                                                                        
npm notice 818B   modules/checks.js                                                                                                                                                                                                
npm notice 1.2kB  modules/checks/check-your-website.js                                                                                                                                                                             
npm notice 673B   modules/checks/crtsh.js                                                                                                                                                                                          
npm notice 958B   modules/checks/cryptcheck.js                                                                                                                                                                                     
npm notice 781B   modules/checks/hstspreload.js                                                                                                                                                                                    
npm notice 859B   modules/checks/httpobservatory.js                                                                                                                                                                                
npm notice 949B   modules/checks/lighthouse.js                                                                                                                                                                                     
npm notice 1.2kB  modules/checks/psi.js                                                                                                                                                                                            
npm notice 682B   modules/checks/securityheaders.js                                                                                                                                                                                
npm notice 1.4kB  modules/checks/ssllabs.js                                                                                                                                                                                        
npm notice 828B   modules/checks/webbkoll.js                                                                                                                                                                                       
npm notice 1.1kB  modules/checks/webhint.js                                                                                                                                                                                        
npm notice 2.0kB  modules/checks/yellowlab.js                                                                                                                                                                                      
npm notice 491B   modules/cli-help.js                                                                                                                                                                                              
npm notice 294B   modules/create-datetime-string.js                                                                                                                                                                                
npm notice 377B   modules/create-folders.js                                                                                                                                                                                        
npm notice 276B   modules/error-handler.js                                                                                                                                                                                         
npm notice 362B   modules/retry.js                                                                                                                                                                                                 
npm notice 459B   modules/set-output.js                                                                                                                                                                                            
npm notice 224B   modules/setup.js                                                                                                                                                                                                 
npm notice 253B   modules/success-handler.js                                                                                                                                                                                       
npm notice 149B   modules/teardown.js                                                                                                                                                                                              
npm notice 203B   modules/url-check.js                                                                                                                                                                                             
npm notice 1.8kB  package.json                                                                                                                                                                                                     
npm notice 684B   utils/process-argv.js                                                                                                                                                                                            
npm notice 35.0kB yarn-error.log                                                                                                                                                                                                   
npm notice === Tarball Details ===                                                                                                                                                                                                 
npm notice name:          @website-checks/website-checks                                                                                                                                                                           
npm notice version:       1.20.0                                                                                                                                                                                                   
npm notice filename:      @website-checks/website-checks-1.20.0.tgz                                                                                                                                                                
npm notice package size:  22.5 kB                                                                                                                                                                                                  
npm notice unpacked size: 69.8 kB                                                                                                                                                                                                  
npm notice shasum:        16d817ac3d157be7332851611b4693458194c31b                                                                                                                                                                 
npm notice integrity:     sha512-AU1qu6fJAC+V3[...]pQ7TdEq7l1w2w==                                                                                                                                                                 
npm notice total files:   37                                                                                                                                                                                                       
npm notice                                                                                                                                                                                                                         
npm ERR! code ENEEDAUTH                                                                                                                                                                                                            
npm ERR! need auth This command requires you to be logged in.                                                                                                                                                                      
npm ERR! need auth You need to authorize this machine using `npm adduser`                                                                                                                                                          
                                                                                                                                                                                                                                   
npm ERR! A complete log of this run can be found in:                                                                                                                                                                               
npm ERR!     C:\Users\Isaak\AppData\Local\npm-cache\_logs\2021-08-29T13_00_00_792Z-debug.log                                                                                                                                       
PS C:\Users\Isaak\Projects\js\website-checks> 

Any ideas @DanielRuf

@myisaak myisaak reopened this Aug 29, 2021
@DanielRuf
Copy link
Contributor Author

Did you remove this from your local package.json file?

https://github.com/website-checks/website-checks/blob/main/package.json#L60

You can check that by increasing the verbosity of the npm publish command with npm publish --verbose.

@DanielRuf
Copy link
Contributor Author

I think we can safely remove the publishConfig config now as we don't publish on GitHub Packages Registry for now (anymore).

@DanielRuf
Copy link
Contributor Author

And I think the readme can be also updated to reflect that.

@myisaak
Copy link
Collaborator

myisaak commented Aug 29, 2021

Agreed. Given that almost everybody in Node uses npm as their repository (unlike with Deno), we should default to NPM instead.

@myisaak
Copy link
Collaborator

myisaak commented Aug 29, 2021

Thanks @DanielRuf for the tip. Now it works!

@myisaak myisaak closed this as completed Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants