-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some pages open in full screen not <Iframe> #6
Comments
Hello, @Holdimas. We will fix "full screen" issue in #7. About second issue: Looks like site has JS checks for current domain and show blank page in case of opening it from other domains. |
I see, thank you for this information. Also can I still append custom scripts and custom styling to the scraped web page in <iframe>? For instance a css selector? |
Hi @Holdimas |
Good day @s0ph1e , it's okay I solved the styling issue with jQuery. |
@Holdimas this app is only a demo for npm module website-scraper, you can't do it in this app because it just downloads pages from given url without any transformation. But you can try to use scrape({
urls: ['http://example.com/'],
directory: '/path/to/save',
httpResponseHandler: (response) => {
if (isHtml) {
const bodyWithScripts = appendScriptsToBody(response.body);
return Promise.resolve(bodyWithScripts);
} else {
return Promise.resolve(response.body);
}
}
}); |
I'm learning your script and looking at the demo app. And noticed that some sites are being opened in full screen not iframe for example this page "http://www.delfi.lt/", which is a news page.
I'm not sure but the problem might be here
The text was updated successfully, but these errors were encountered: