Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation doesn't work on tablet devices #79

Closed
jlantunez opened this issue Apr 26, 2017 · 7 comments
Closed

Navigation doesn't work on tablet devices #79

jlantunez opened this issue Apr 26, 2017 · 7 comments
Labels
Milestone

Comments

@jlantunez
Copy link
Member

This is weird. Tested on iPad (Safari, Chrome, and Firefox). Ryan uploaded a video. We will fix asap!

@jlantunez jlantunez added the bug label Apr 26, 2017
@jlantunez jlantunez added this to the 1.3.1 milestone Apr 26, 2017
@englishextra
Copy link

englishextra commented Nov 19, 2017

swipe on android 6.0.1 chrome browser seems to work fine, firfox browser 57.0 slides change in the wrong order - in mystrious ways.

The other important and UGLY thing about the library is why would you use mobile-detector.js
which relies on UA string instead of detecting if touch is available and switch to swipe navigation based on that. It's bad because, say, you cannot debug and test the code on desktop browser with touch events simulation enabled in mobile responsive view - SHFT + CTRL + M in firefox, for instance.

So for now I have to disable webslides at all if my hasTouch is true or the screen is small so that to reveal all slides and in that case the webslides is useless.

BTW why did you close the issue? Did you make some fixes?

@Antonio-Laguna
Copy link
Member

Hey @englishextra not sure what the issue is in Firefox, it looks fine to me. What are you experiencing?

We went with the UGLY option because we want to base that on devices, not touch only. Chromebooks, for example, would trigger touch and that wouldn't be intentional. I was able to debug and test the code on a desktop browser, such as Chrome, as it does change the UA.

Feel free to tinker with the Touch class in your project and adjust it to your needs.

@englishextra
Copy link

@Antonio-Laguna you pretended not to understand the issue switching the attention to debug issue.
Once again:

firfox browser 57.0 slides change in the wrong order
that's on android 6 Android 6

@Antonio-Laguna
Copy link
Member

Antonio-Laguna commented Dec 5, 2017

And you're being pretty rude. I don't have an android 6 Android 6 so there's no way for me to test that. Feel free to test on your device and submit a PR if you do find a fix. I answered your concern, not switched attention.

@englishextra
Copy link

@Antonio-Laguna I'm afraid, you didn't. For now, I just disable the library on touch devices.

@Antonio-Laguna
Copy link
Member

I did answer, you just didn't like the answer which is another story.

@englishextra
Copy link

englishextra commented Dec 5, 2017

@Antonio-Laguna have a look at this issue here GianlucaGuarini/Tocca.js#54

I'm pretty sure there is a connection with this very issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants