Add _socket to stream

[robertsLando]

When using createWebSocketStream the duplex returned doesn't have any _socket property. Is it possible to add it?

moscajs/aedes#413

[lpinca]

I prefer not. The user should not mess with the internal {net,tls}.Socket. You can get it from the WebSocket object if you really need it, before passing the WebSocket object to createWebSocketStream(). On the client you need to wait for the 'open' event.

[robertsLando]

@lpinca This is how I'm doing it now, I moved to ws from websocket-stream and in websocket-stream I also had that property in the duplex.

[lpinca]

Why you need to access the internal socket?

[robertsLando]

To be able to get informations about connection details (remoteIp, ipFamily etc..) from the stream

[lpinca]

You can grab that info from the http.IncomingMessage object that is emitted when the 'connection' event is emitted.

wss.on('connection', function(ws, request) {
  // `request` has all the data including the socket itself.
});

https://github.com/websockets/ws#how-to-get-the-ip-address-of-the-client

[robertsLando]

@lpinca Yes that is how I'm doing it right now, It's not a problem I was just asking if maybe it could be possibile and useful to others add that _socket property to the stream

[lpinca]

No thanks, _socket is "private" for good reasons. See also #1688.