Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

permessage-deflate does not work with Chrome. #594

Closed
yutakahirano opened this issue Oct 1, 2015 · 2 comments
Closed

permessage-deflate does not work with Chrome. #594

yutakahirano opened this issue Oct 1, 2015 · 2 comments

Comments

@yutakahirano
Copy link

Please see https://code.google.com/p/chromium/issues/detail?id=536627 for the minimized test case.

In "finish" functions in Receiver.js, incoming data is stored to a variable |data|, a.k.a. |packet|. The data may be modified after the function returns (I assume calling |endPacket| is the trigger but I'm not sure), but permessage-deflate module uses the data after that. As a result it sees modified data and that leads to deflate errors.

@yutakahirano
Copy link
Author

This may be related to #585.

@nkzawa
Copy link
Contributor

nkzawa commented Oct 1, 2015

Thanks for your report! Will fix asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants