Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nasty client memory leak #629

Closed
rorph opened this issue Dec 10, 2015 · 3 comments
Closed

Nasty client memory leak #629

rorph opened this issue Dec 10, 2015 · 3 comments

Comments

@rorph
Copy link

rorph commented Dec 10, 2015

I've been using ws client on server-side to do multiplexing, turns out it has a nasty memory leak on upgradeHeader handler.

The server was patched, but looks like the client wasn't.
I'm attaching a patch file with the fix for this.

WebSocket.patch

Cheers

@Eeems
Copy link

Eeems commented Dec 10, 2015

You may want to open a pull request instead of attaching a patch file.

@rupamkhaitan
Copy link

Is this patch for memory leak on the server side?
We use ws library to open socket connection on our server side, will this patch have impact on memory leak on server side?

@JoshuaWise
Copy link
Member

If anyone is still experiencing this, please reopen the issue of submit a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants