[minor] added --hide-ping for hiding 'Received ping' and pong messages #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that it's better to make the "print ping/pong" feature opt-in with a cli argument. I don't mind if the change is semver-major. |
This was referenced Nov 16, 2019
|
version with opt-in ping: #113 |
|
#113 was merged instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intended to fix #107 and provide a workaround for #84
functionality
When using a
-Por--hide-ping, the blue< Received ping(and pong) messages stop appearing in the console, which allows for a clean uninterrupted copy-pasteable transcript of the ws conversation.This is opt-in to keep the change minor. I would suggest to make this default in the next major version