Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 2.0.0 #35

Closed
nwwells opened this issue Feb 21, 2017 · 8 comments
Closed

release 2.0.0 #35

nwwells opened this issue Feb 21, 2017 · 8 comments
Assignees

Comments

@nwwells
Copy link
Collaborator

nwwells commented Feb 21, 2017

@lpinca, @3rd-Eden, @einaros... I don't have access on npm to publish this package, but I made some changes that will fix a few issues. Can you please release 1.2.0 or give me access to?

@lpinca
Copy link
Member

lpinca commented Feb 21, 2017

@nwwells #34 is a breaking change so it must be a major (2.0.0).

@lpinca
Copy link
Member

lpinca commented Feb 21, 2017

Let me know if you want to add more breaking changes like using ES6 features where possible before releasing 2.0.0 or you are good as is.

@nwwells
Copy link
Collaborator Author

nwwells commented Feb 21, 2017

How is it breaking? the command line API stays the same, no?

@lpinca
Copy link
Member

lpinca commented Feb 21, 2017 via email

@nwwells
Copy link
Collaborator Author

nwwells commented Feb 21, 2017

Ah. I'm down with a 2.0 upgrade then. I'll make the change and get back with you here soon

@nwwells
Copy link
Collaborator Author

nwwells commented Feb 21, 2017

fixed in c6dfcf8

@nwwells nwwells changed the title release 1.2.0 release 2.0.0 Feb 21, 2017
@lpinca
Copy link
Member

lpinca commented Feb 21, 2017

@nwwells ok I'll cut the release later or tomorrow. Please never bump the package.json version as we use a dedicated commit for the release like b682807.

@nwwells
Copy link
Collaborator Author

nwwells commented Feb 21, 2017

Understood.

@lpinca lpinca closed this as completed Feb 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants