New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Floating panel max height needs to be set #1158

Closed

kof opened this issue Mar 1, 2023 · 0 comments · Fixed by #1160

Assignees

Labels

prio:1 type:bug

Member

kof commented Mar 1, 2023

For example images picker grows beyond the screen right now

kof added type:bug prio:1 labels

kof self-assigned this

kof linked a pull request

that will close this issue

Set a meaningful default maxHeight #1160

Merged

7 tasks

kof mentioned this issue

Set a meaningful default maxHeight #1160

Merged

7 tasks

kof closed this as completed in #1160

kof added a commit that referenced this issue


          Set a meaningful default maxHeight (#1160)

4060e2f

closes #1158

to prevent panel taking more than screen height


## Steps for reproduction

1. upload lots of images
2. see they are scrollable in image manager when choosing source from
properties or background image
<img width="546" alt="Screenshot 2023-03-01 at 15 11 04"
src="https://user-images.githubusercontent.com/52824/222181464-38e70ced-c2d4-4d8c-b788-4428d5a35c11.png">
<img width="516" alt="Screenshot 2023-03-01 at 15 11 22"
src="https://user-images.githubusercontent.com/52824/222181469-7d170a91-8597-4b7f-8c4e-a56114f0f0ef.png">


## Code Review

- [ ] hi @TrySound , I need you to do
  - conceptual review (architecture, feature-correctness)

## Before requesting a review

- [ ] made a self-review
- [ ] added inline comments where things may be not obvious (the "why",
not "what")

## Before merging

- [ ] tested locally and on preview environment (preview dev login:
5de6)
- [ ] updated [test
cases](https://github.com/webstudio-is/webstudio-builder/blob/main/apps/builder/docs/test-cases.md)
document
- [ ] added tests
- [ ] if any new env variables are added, added them to `.env.example`
and the `builder/env-check.js` if mandatory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment