Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render tree with normalized data #1267

Merged
merged 1 commit into from Mar 19, 2023
Merged

Render tree with normalized data #1267

merged 1 commit into from Mar 19, 2023

Conversation

TrySound
Copy link
Member

We finally able to use normalized data to render tree. A few last improvements in tree drag and drop add support for slots with duplicating ids within tree.

Code Review

  • hi @kof, I need you to do
    • conceptual review (architecture, feature-correctness)
    • detailed review (read every line)
    • test it on preview

Before requesting a review

  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the builder/env-check.js if mandatory

We finally able to use normalized data to render tree.
A few last improvements in tree drag and drop add support for slots with
duplicating ids within tree.
@TrySound TrySound requested a review from kof March 18, 2023 18:51
@vercel
Copy link

vercel bot commented Mar 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
webstudio-builder ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 18, 2023 at 6:52PM (UTC)

@TrySound TrySound merged commit c815f06 into main Mar 19, 2023
11 checks passed
@TrySound TrySound deleted the modern-tree branch March 19, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants