Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Github Actions #250

Merged
merged 14 commits into from
Sep 2, 2022
Merged

fix: Github Actions #250

merged 14 commits into from
Sep 2, 2022

Conversation

andrasbacsai
Copy link
Contributor

@andrasbacsai andrasbacsai commented Aug 31, 2022

There are 2 Github Actions flows:

  1. Push changes to package dirs in any branch -> Only run npm publish with --dry-run, so contributors could check if the packages build correctly.
  2. Push changes to main branch -> Run npm publish without --dry-run, production publish.

Before requesting a review

  • if the PR is WIP - use draft mode
  • made a self-review
  • added inline comments where things may be not obvious (the "why", not "what")
  • what kind of review is needed?
    • conceptual
    • detailed
    • with testing

Test cases

  • step by step interaction description and what is expected to happen

Before merging

  • tested locally and on preview environment (preview dev login: 5de6)
  • updated test cases document
  • added tests
  • if any new env variables are added, added them to .env.example and the designer/env-check.js if mandatory

@vercel
Copy link

vercel bot commented Aug 31, 2022

@andrasbacsai is attempting to deploy a commit to the webstudio-is Team on Vercel.

A member of the Team first needs to authorize it.

@andrasbacsai andrasbacsai marked this pull request as ready for review August 31, 2022 09:27
@andrasbacsai andrasbacsai requested a review from kof August 31, 2022 09:27
Copy link
Member

@kof kof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check that:

  1. Contributor can run it locally
  2. Checks can pass on CI
  3. Preview works

@andrasbacsai andrasbacsai mentioned this pull request Sep 2, 2022
@vercel
Copy link

vercel bot commented Sep 2, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
webstudio-designer ❌ Failed (Inspect) Sep 2, 2022 at 1:14PM (UTC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants