Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pasting in system variables when they are written in plain text #3401

Closed
johnsicili opened this issue May 22, 2024 · 0 comments · Fixed by #3403
Closed

Allow pasting in system variables when they are written in plain text #3401

johnsicili opened this issue May 22, 2024 · 0 comments · Fixed by #3403
Assignees
@TrySound
Labels
area:cms All CMS related issues area:settings Settings panel on the right prio:2 Always look for prio:1 issues first before working on prio:2 type:enhancement New feature or request

Comments

@johnsicili
Copy link
Contributor

When I'm writing tutorial I want to tell the user to to paste in the following for example

`https://example.com?filterByFormula={slug}="${system.params.slug}"`

So would be great if system was translated to the internal system var.
@johnsicili johnsicili added type:enhancement New feature or request area:settings Settings panel on the right prio:2 Always look for prio:1 issues first before working on prio:2 labels May 22, 2024
@kof kof added the area:cms All CMS related issues label May 22, 2024
TrySound added a commit that referenced this issue May 22, 2024
@TrySound
feat: match unambiguous variables by name
8bd2d60 
Fixes #3401

Simple logic here, one variable matched by name then can be replaced
with actual variable id otherwise user has to select variable
explicitly.
@TrySound TrySound mentioned this issue May 22, 2024
Merged
TrySound added a commit that referenced this issue May 23, 2024
@TrySound
feat: match unambiguous variables by name (#3403)
d95158b 
Fixes #3401
Ref #3080

Simple logic here, one variable matched by name then can be replaced
with actual variable id otherwise user has to select variable
explicitly.

<img width="342" alt="Screenshot 2024-05-23 at 00 37 07"
src="https://github.com/webstudio-is/webstudio/assets/5635476/a4620f5e-2816-421c-b384-087fe7ea1ded">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TrySound TrySound

Labels
area:cms All CMS related issues area:settings Settings panel on the right prio:2 Always look for prio:1 issues first before working on prio:2 type:enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: match unambiguous variables by name webstudio-is/webstudio
3 participants
@kof @TrySound @johnsicili