Various smaller errors captured in php_error.log

[danielmarschall]

I wanted to share some error messages which I captured in php_error.log
I hope this helps!

I would like to help you with PRs, but I am not familar enough with this code yet, and I don't want to suggest anything wrong :)

include/diff_util.php

=> (Edit): Is now #196

PHP Warning: Undefined variable $n in .../websvn/include/diff_util.php on line 243
PHP Warning: Undefined variable $n in .../websvn/include/diff_util.php on line 247
PHP Warning: Undefined variable $m in .../websvn/include/diff_util.php on line 251

blame.php

=> (Edit): Is now #197

PHP Warning: Attempt to read property "date" on null in .../websvn/blame.php on line 247
PHP Warning: Attempt to read property "msg" on null in .../websvn/blame.php on line 247

search.php

=> (Edit): Is now #198

PHP Warning: Undefined array key "search" in .../websvn/search.php on line 373
PHP Warning: Undefined array key "NOSEARCHTERM" in .../websvn/search.php on line 375

include/svnlook.php

=> (Edit): Is now #199

PHP Warning: require_once(geshi.php): failed to open stream: No such file or directory in .../websvn/include/svnlook.php on line 758

[michael-o]

We need to go through piece by piece. Thanks for the report.

[michael-o]

Can you tell how to reproduce the issue with blame.php? This must be some constellation...

[michael-o]

I consider the issue in include/svnlook.php as invalid because it is only happens when you enable Geshi highlighting, don't use composer, but are expected to manually drop geshi or use pear to install it.

[danielmarschall]

For blame.php , I could track down the call in access.log .

Warning: Attempt to read property "date" on null in /daten/homes/svn/public_html/websvn/blame.php on line 247

Warning: Attempt to read property "msg" on null in /daten/homes/svn/public_html/websvn/blame.php on line 247

happens in https://svn.viathinksoft.com/websvn/blame.php?path=%2Ftags%2FUserDetect2_Release_2.0%2FPlugins%2FExecuteAlways.dpr&repname=userdetect2&rev=70

[michael-o]

For blame.php , I could track down the call in access.log .

Warning: Attempt to read property "date" on null in /daten/homes/svn/public_html/websvn/blame.php on line 247

Warning: Attempt to read property "msg" on null in /daten/homes/svn/public_html/websvn/blame.php on line 247

happens in https://svn.viathinksoft.com/websvn/blame.php?path=%2Ftags%2FUserDetect2_Release_2.0%2FPlugins%2FExecuteAlways.dpr&repname=userdetect2&rev=70

Thanks, let me try to understand that.

[danielmarschall]

In case you want to checkout the raw SVN, here is the server
svn co https://svn.viathinksoft.com/svn/userdetect2/trunk

I will try to find the access.log entry for the other reported PHP warnings.

[danielmarschall]

Just a theory: Is it possible that the invalid UTF-8 character "Immer ausf�hren" is the reason why blame.php fails? (The file is ISO-8859-1 formatted)

[michael-o]

Since this is a tag, I have the feeling that svn log does (not) return something WebSVN expects. I need to construc the raw command first.

[danielmarschall]

I never use tags in SVN
Sorry, it looks like I did that once.

[danielmarschall]

Error in include/diff_util.php found in

https://svn.viathinksoft.com/websvn/diff.php?repname=winbugtracker&path=%2Ftrunk%2Fbugtracker_mysql.sql&rev=6&ignorews=0

(btw, should I split this up in different Github issues?)

[michael-o]

Blame issue:

Error in include/diff_util.php found in

https://svn.viathinksoft.com/websvn/diff.php?repname=winbugtracker&path=%2Ftrunk%2Fbugtracker_mysql.sql&rev=6&ignorews=0

(btw, should I split this up in different Github issues?)

Yes, please.

[danielmarschall]

(I have split the issues in #196 till #199 . I'm sorry that I didn't do that at the beginning)