Psd.composite() note about "Maximize Compatibility" #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFAIK only the pixel data of the entire image needs the PSD/PSB to be saved with "Maximize Compatibility". I've tested this. I didn't test for `layer.composite()`. I suspect layers don't need it.
|
Thank you! We appreciate your PR. LGTM but could you fix the small typo ("maximizize")? If you don't have the time, I can fix it tomorrow. |
|
Of course! I've just fixed it 馃槉 |
pastelmind
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAIK only the pixel data of the entire image needs the PSD/PSB to be saved with "Maximize Compatibility". I've tested this.
I didn't test for
layer.composite(). I suspect layers don't need it.By the way: beautiful library!! I've just tested it with ZMOK coming from psd.js and made really noticeable speed improvements. Impressive work 馃帀