Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge data from multiple peers #6

Closed
feross opened this issue Jun 4, 2014 · 1 comment
Closed

Merge data from multiple peers #6

feross opened this issue Jun 4, 2014 · 1 comment

Comments

@feross
Copy link
Member

feross commented Jun 4, 2014

This is a minor optimization.

Merge metadata from multiple peers to return metadata more quickly.

Need to be careful. If one peer consistently sends bad data, you'll get stuck retrying for a long time and have no idea which peer sent the bad data.

Here's how it will work: Assume peers are all good. Merge metadata from all peers together, but also keep metadata per-peer (like we're doing now). Merged metadata should finish fastest. If it matches sha1 hash, great, we're done! If not then just take metadata from first peer (like we're doing now).

@feross
Copy link
Member Author

feross commented Jul 2, 2015

I have no plans to implement this. PR welcome if someone else wants to.

@feross feross closed this as completed Jul 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant