Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display multiple torrents #224

Closed
br3ndonland opened this issue Feb 5, 2022 · 9 comments
Closed

Display multiple torrents #224

br3ndonland opened this issue Feb 5, 2022 · 9 comments
Labels

Comments

@br3ndonland
Copy link

What version of this package are you using? 4.0.3

What problem do you want to solve? Display info about multiple torrents

What do you think is the correct solution to this problem? Display each torrent being downloaded or seeded

Are you willing to submit a pull request to implement this change? Yeah, could totally take a stab at it

Description

Thanks for WebTorrent! 💖

webtorrent-cli can download multiple torrents by passing multiple filepaths or magnet links as arguments, like webtorrent download *.torrent. This multi-torrent support is helpful.

When more than one torrent is specified, webtorrent-cli automatically enables quiet mode (equivalent to the --quiet flag):

webtorrent-cli/bin/cmd.js

Lines 831 to 839 in bbbe6ef

invalidArguments.forEach(arg => {
if (argv[arg]) {
return errorAndExit(new Error(
`The --${arg} argument cannot be used with multiple files/folders.`
))
}
})
torrentCount = inputs.length
enableQuiet()

This means the user is unable to see the status of any of the torrents.

Suggestions

It would be great to have a compact display of each torrent being downloaded or seeded.

I would propose something like this:

  • Display each torrent in 1-2 lines, with select metadata:
    • name
    • download speed and size
    • upload speed and size
    • peers
  • When the number of torrents exceeds the height of the terminal window, abbreviate the list like ... and <n> more (the current behavior for displaying peers)

It might look like this:

Example of webtorrent-cli multi-torrent display in a terminal, made with carbon.now.sh

It's probably a good idea to support the --quiet flag, in case users want to preserve the existing behavior.

Related

Torrents from screenshot:

@github-actions
Copy link

github-actions bot commented Apr 7, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Apr 7, 2022
@DiegoRBaquero
Copy link
Member

This would be great! happy to review a PR :)

@github-actions
Copy link

github-actions bot commented Jun 8, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Jun 8, 2022
@br3ndonland
Copy link
Author

yes #240

@github-actions github-actions bot removed the stale label Jun 10, 2022
@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Aug 10, 2022
@br3ndonland
Copy link
Author

yes #240

@github-actions github-actions bot removed the stale label Aug 12, 2022
@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

@github-actions github-actions bot added the stale label Oct 11, 2022
@br3ndonland
Copy link
Author

yes #240

@github-actions github-actions bot removed the stale label Oct 12, 2022
@github-actions
Copy link

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants