fix: webrtc import #143
Merged
fix: webrtc import #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🙌 Thanks for opening this pull request! You're awesome. |
DiegoRBaquero
approved these changes
Sep 8, 2021
gdborton
force-pushed
the
wrtc-module
branch
from
ea8dcc5
to
5266cc1
Compare
|
With which error does it fail? |
|
🎉 Congrats on getting your first pull request landed! |
webtorrent-bot
pushed a commit
that referenced
this pull request
Sep 14, 2021
## [5.0.1](v5.0.0...v5.0.1) (2021-09-14) ### Bug Fixes * webrtc import ([#143](#143)) ([3b5d9bb](3b5d9bb))
|
🎉 This PR is included in version 5.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
The recent esm update changed the structure of the resulting wrtc object, this breaks web peers in webtorrent-hybrid.
I found that this change makes simple-peer fail on this line:
https://github.com/feross/simple-peer/blob/master/index.js#L101
Which issue (if any) does this pull request address?
Is there anything you'd like reviewers to focus on?