Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support webtorrent in PWA's #2306

Closed
unicomp21 opened this issue Apr 27, 2022 · 6 comments
Closed

Support webtorrent in PWA's #2306

unicomp21 opened this issue Apr 27, 2022 · 6 comments

Comments

@unicomp21
Copy link

mdn/content#15242 (comment)

@ThaUnknown
Copy link
Member

this is helpful how?
why PWA's only? its not exclusive to PWA's?

@unicomp21
Copy link
Author

Think Occulus based webgl applications which need to download large amounts of meshes etc. No, it does not need to be specific to PWA's I suppose. But, it would be nice if there was an api consumable from the app side, which automatically takes care of all the ServiceWorker concerns (ie the datachannel is running in the serviceworker)

@ThaUnknown
Copy link
Member

i still dont understand what 3d rendering and VR has to do with webtorrent

it can't be ran in a worker anyways, you still need to manage all the connections and webrtc on the main thread, and push the streams to the workers.

not only would this become incompatible with node, you'd need to re-write webtorrent from scratch just to implement this, and you wouldn't even be saving any resources, just introducing more compatibility issues and overhead

webrtc isnt what takes up the most CPU time in webtorrent right now, but the node readable-stream polyfill

@unicomp21
Copy link
Author

Are we saying the new "transferable" rtcdatachannel cannot be transferred to a serviceworker? Did you look at the link above?

@ThaUnknown
Copy link
Member

Are we saying the new "transferable" rtcdatachannel cannot be transferred to a serviceworker? Did you look at the link above?

what???
this reply feels like you took the entire message I wrote above, pushed it to the side, and came up with your own response and put it there instead of my message.
neither the word "service worker" or "transferable" showed up in my reply, I don't understand where you're coming from

@ThaUnknown
Copy link
Member

as WebTorrent is "supported in PWA's" as is visible by this list, and the issue fails to describe if it's meant to be an enhancement, feature request or bug report, instead points to a pending implementation, I'm gonna treat this as "low effort trolling" and close it

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants