Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Revert "fix: correctly destroy piped streams in server" #2585

Merged
merged 2 commits into from
Jun 15, 2023
Merged

fix: Revert "fix: correctly destroy piped streams in server" #2585

merged 2 commits into from
Jun 15, 2023

Conversation

ThaUnknown
Copy link
Member

@ThaUnknown ThaUnknown commented Jun 15, 2023 •
edited
Loading

Reverts #2565

makes stream/iterator check less strict

@ThaUnknown
Copy link
Member Author

at this point it feels obligatory i fuck up every 3-4 months

@ThaUnknown ThaUnknown enabled auto-merge (squash) June 15, 2023 19:45
@ThaUnknown ThaUnknown disabled auto-merge June 15, 2023 19:45
@ThaUnknown ThaUnknown enabled auto-merge (squash) June 15, 2023 19:46
@ThaUnknown ThaUnknown merged commit e3c9269 into master Jun 15, 2023
5 checks passed
@ThaUnknown ThaUnknown deleted the revert-2565-stream-state-fix branch June 15, 2023 19:50
webtorrent-bot pushed a commit that referenced this pull request Jun 15, 2023
@semantic-release-bot
chore(release): 2.1.1
184c428 
## [2.1.1](v2.1.0...v2.1.1) (2023-06-15)

### Bug Fixes

* Revert "fix: correctly destroy piped streams in server" ([#2585](#2585)) ([e3c9269](e3c9269)), closes [#2565](#2565)
@webtorrent-bot
Copy link
Collaborator

🎉 This PR is included in version 2.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SilentBot1 SilentBot1 SilentBot1 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ThaUnknown @webtorrent-bot @SilentBot1