fix: perf: faster stream resolution #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilentBot1
reviewed
Jul 5, 2023
SilentBot1
approved these changes
Jul 5, 2023
webtorrent-bot
pushed a commit
that referenced
this pull request
Jul 5, 2023
## [2.1.12](v2.1.11...v2.1.12) (2023-07-05) ### Bug Fixes * perf: faster stream resolution ([#2607](#2607)) ([e692270](e692270))
|
🎉 This PR is included in version 2.1.12 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
This fixes an issue that caused iterators to sometimes hang for a very long time, and also cleans up some code.
The notify() function wasn't called for each piece [I think....] which caused the streams to sometimes hang for a very long time before being resolved, this was simply annoying and I shiver at the thought of how long this issue has existed, since this code was originally copied from file streams.
This creates a lot of event calls since it's now done for all pieces, not just the ones we're interested in, but speeds up streams a lot.