Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve webrtc peer connection handling #338

Closed
feross opened this issue Jun 1, 2015 · 4 comments
Closed

Improve webrtc peer connection handling #338

feross opened this issue Jun 1, 2015 · 4 comments
Milestone

Comments

@feross
Copy link
Member

@feross feross commented Jun 1, 2015

  • need to cleanup closed/errored webrtc peers from the swarm
  • need to cleanup unused peers when tracker doesn't respond any answers (add a timeout)
  • need to increase number of offers (maybe to 25?)
  • need to re-announce to tracker every 5 minutes (instead of 15 minutes) since peers are probably shorter-lived
@feross feross changed the title Improve webrtc peer connections Improve webrtc peer connection handling Jul 1, 2015
@feross feross added this to the Alpha milestone Jul 8, 2015
@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Jul 29, 2015

I just pushed an improvement to the tracker module, so we now try to look for new peers every 30 seconds on the already-established WebSocket connection to the tracker.

@DiegoRBaquero

This comment has been minimized.

Copy link
Member

@DiegoRBaquero DiegoRBaquero commented Dec 14, 2015

@feross The first two, I think they can be checked with the recent peer destroy update.

@feross

This comment has been minimized.

Copy link
Member Author

@feross feross commented Jan 1, 2016

@DiegoRBaquero Yep, thanks. Going to close this now.

@feross feross closed this Jan 1, 2016
@lock

This comment has been minimized.

Copy link

@lock lock bot commented May 5, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.