-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs may be outdated; example scripts are not working. #10
Comments
Related to this issue |
I will re-test it on macOS tomorrow. |
Thanks, Hassan. I got around the first issue by following the issue you linked and pulling the repo. However, the Mac issue seems to be because WebUI expects a different CPU architecture. |
You are right, we need to add the ARM64 lib into the repo. I will do it tomorrow. |
Just a friendly bump that most of the stuff in the readme still doesn't run |
Yep, running into the same stuff. Have it working on Apple Silicon by checking out the tree and using the library directly but the deno.land stuff is out of date. Also FWIW on latest MacOS with Chrome I'm just getting the UI opening in the full browser itself instead of the raw frame. |
WebUI does not support Safari app mode yet. Firefox or any Chromium-based browser should be installed first to use app mode. Otherwise, WebUI will try to open the UI in the default macOS browser window, which will be in most cases Safari (Not app-mode). On the other hand, WebUI v2.4.0 has been released... We will update the Deno-WebUI wrapper soon. |
Okay then you probably want to change the Readme.md cause it says
If the system needs a browser installed, then I wouldn't really call this library "fully independent". A browser is a third party JavaScript/Wasm runtime. |
On one side, yes. In another, no. All programs in all OS need hundreds or thousands of libs, drivers, runtime, etc. All those are built-in in the OS, so nobody talks about it because it's already installed. A web browser is one of them. Conversely, because Deno-webui needs Chromium browsers and not Safari, it is a third party then, as you said. I suggest adding in the readme that a Chromium-based browser is needed. |
All I'm saying is the readme should say:
It might seem small, but it has really big implications. Saying "no 3rd party runtime" makes it sound like WebUI is providing the runtime, and that the runtime will be consistent across OS's which isn't the case.
(not always true, see cosmopolitan libc) but there is a big difference between needing libc and a broswer. Libc is part of the spec for Mac/Linux/Windows. Browsers are not part of the spec for Linux. Saying it needs a browser runtime tells me it's potentially unreliable on Linux; which is fine, but very important to know. And some credit is due, as the readme does talk about the exact libraries used (like gtk), which is great.
Fair enough, I should revise my statement. Browsers are 3rd party runtimes on some OS's. But especially in Docker, and even on Ubuntu, Firefox is not guaranteed, if it exists it's not guaranteed to be in the same place, and even if it's in the same place it can be any version of Firefox, and can be upgraded without upgrading the OS. It's a sometimes-pre-bundled 3rd party runtime.
It works for Firefox so I don't think this would be accurate. |
Honestly, this is not a bad idea, we should add in the readme that a web browser is needed at runtime. |
Also can confirm readme example is working 👌 So this can probably be closed |
I tried running the Minimal Example and the Repository Examples but neither seems to work anymore.
The former gives the error:
and the latter gives the error:
My current environment is like so:
Has anyone else encountered this issue?
The text was updated successfully, but these errors were encountered: