New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename env PLUGIN_URL #145

Open

milahu opened this issue Oct 13, 2022 · 0 comments

milahu commented Oct 13, 2022 •

edited

the env name should be more absolute than PLUGIN_URL

webview_deno/src/ffi.ts

Lines 4 to 7 in 9c3bff6

    
           const version = "0.7.3"; 
        
           const cache = Deno.env.get("PLUGIN_URL") === undefined ? "use" : "reloadAll"; 
        
           const url = Deno.env.get("PLUGIN_URL") ?? 
        
             `https://github.com/webview/webview_deno/releases/download/${version}/`;

this env holds the folder of libwebview.so so rename to ...

WEBVIEW_DENO_LIBWEBVIEW?
WEBVIEW_DENO_LIB?
DENO_LIBWEBVIEW?
DENO_WEBVIEW_LIB?

also its not an (optional) "plugin" but an essential dependency

fix merged in https://github.com/milahu/webview_deno

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment