Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support net framework? #8

Closed
weianweigan opened this issue Jan 24, 2023 · 1 comment
Closed

Support net framework? #8

weianweigan opened this issue Jan 24, 2023 · 1 comment

Comments

@weianweigan
Copy link
Contributor

Hi, this is a awsome project.
I want to use it in my work, but i found that it cannot used in .net framework's wpf project.
So i forked it and add net461 to TargetFrameworks.

This is my commit.
I changed a few lines of code to compile and passed testcase.
It passed unittests but I don't konw if there is some other problems when i use it in .net framework.
If there is no major problem, Could i create a pr for this?

@mattkol
Copy link
Contributor

mattkol commented Jan 28, 2023

@weianweigan sure, please create the PR, it would help other developers using .NET Framework.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants