German special characters are weird on OSX

[hirasso]

Hi there,

your plugin looks so great, but I always had issues to get it to work. Today I had a bit of time to play around with it, and this is what I found out: When I create a file like Ä ö ü.jpg and upload it, the file name doesn't get changed. The german letters just don't match (I tested it).

Now comes the weird part: If I copy the letters from Finder to your script, replacing your (actually correct) german special chars:

    '/Ä/' => 'ae', '/Ö/' => 'oe', '/Ü/' => 'ue', '/ß/' => 'ss',
    '/ä/' => 'ae', '/ö/' => 'oe', '/ü/' => 'ue',

...it suddenly works! It seems like on OSX, an Ä is not represented as the German letter, but as an A with a double-point accent on top (like the french letters). I hope I make myself clear.

The solution would maybe be to just also put my posted code in your array, just after the 'real' german special chars. They look the same, but seemingly they aren't...

[hirasso]

More about my System Settings:
– OSX Language: English
– Keyboard Layout: German

When i edit the above characters afterwards, placing the caret for example after the Ä and the pressing backspace, first the dots disappear and with the second press also the A disappears. They seem to really be different character types to german Umlauts.

[hirasso]

Adding this line to your code, just before the return, would solve edge cases like this out of the box:

$friendly_filename = preg_replace('/[^A-Za-z0-9\-.]/', '', $friendly_filename);